Opened 8 years ago

Closed 8 years ago

#37 closed defect (fixed)

Simulation dependent on PyWavelets

Reported by: flip Owned by: flip
Priority: critical Milestone:
Component: other Version:
Keywords: Cc:

Description

As of Vespa 0.3.1, Simulation (through a chain of imports starting at dialog_mixed_metabolite_output.py) attempts to import pywt (PyWavelets). This is not yet an official requirement for Vespa, so probably no one has this installed, and so Simulation is effectively broken in 0.3.1.

This is easy to fix temporarily. This ticket will help to track what we do about this in the long term.

Change History (4)

comment:2 Changed 8 years ago by flip

import pywt appears in two places. One was in util_voigt.py which was the source of the error reported in the vespa-mrs message above. That import is unused, so it was easy to remove. There's another import in funct_voigt_baseline_model.py. That doesn't seem to be involved in this problem, but I'm moving it inline anyway for the time being to prevent further nasty surprises.

comment:3 Changed 8 years ago by flip

Fixed/Patched in r3000 and r3001

comment:4 Changed 8 years ago by flip

  • Resolution set to fixed
  • Status changed from new to closed

As of r3034, even Analysis can run without PyWavelets installed, so it's safe to say that Simulation is independent of it too.

Note: See TracTickets for help on using tickets.